gochan/gochan
1
0
Fork 0
mirror of https://github.com/Eggbertx/gochan.git synced 2025-08-18 11:46:23 -07:00
Code Releases Activity

Implement in-place board migration

Browse source
This commit is contained in:
Eggbertx 2025-01-25 13:34:33 -08:00
parent 12350cc33f
commit cec68cb29b
3 changed files with 46 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

41
cmd/gochan-migration/internal/pre2021/boards.go
View file

@ -10,28 +10,6 @@ import (
"github.com/rs/zerolog"
)
var (
alterStatements = []string{
"ALTER TABLE DBPREFIXboards RENAME COLUMN section TO section_id",
"ALTER TABLE DBPREFIXboards RENAME COLUMN list_order TO navbar_position",
"ALTER TABLE DBPREFIXboards RENAME COLUMN created_on TO created_at",
"ALTER TABLE DBPREFIXboards RENAME COLUMN anonymous TO anonymous_name",
"ALTER TABLE DBPREFIXboards RENAME COLUMN forced_anon TO force_anonymous",
"ALTER TABLE DBPREFIXboards RENAME COLUMN embeds_allowed TO allow_embeds",
"ALTER TABLE DBPREFIXboards ADD COLUMN uri VARCHAR(45) NOT NULL",
"ALTER TABLE DBPREFIXboards ADD COLUMN min_message_length SMALLINT NOT NULL",
"ALTER TABLE DBPREFIXboards ADD COLUMN max_threads SMALLINT NOT NULL",
"ALTER TABLE DBPREFIXboards DROP COLUMN type",
"ALTER TABLE DBPREFIXboards DROP COLUMN upload_type",
"ALTER TABLE DBPREFIXboards DROP COLUMN max_age",
// the following statements don't work in SQLite since it doesn't support adding foreign keys after table creation.
// "in-place" migration support for SQLite may be removed
"ALTER TABLE DBPREFIXboards ADD CONSTRAINT boards_section_id_fk FOREIGN KEY (section_id) REFERENCES DBPREFIXsections(id)",
"ALTER TABLE DBPREFIXboards ADD CONSTRAINT boards_dir_unique UNIQUE (dir)",
"ALTER TABLE DBPREFIXboards ADD CONSTRAINT boards_uri_unique UNIQUE (uri)",
}
)
type migrationBoard struct {
oldSectionID int
oldID int
@ -59,9 +37,22 @@ func (m *Pre2021Migrator) migrateBoardsInPlace() error {
errEv.Err(err).Caller().Msg("Failed to migrate sections")
return err
}
err = common.NewMigrationError("pre2021", "migrateBoardsInPlace not implemented")
errEv.Err(err).Caller().Msg("Failed to migrate boards")
return err
for _, statement := range alterStatements {
if strings.Contains(statement, "CONSTRAINT") && m.db.SQLDriver() == "sqlite3" {
// skip constraints in SQLite since they can't be added after table creation
continue
}
_, err = m.db.ExecSQL(statement)
if err != nil {
errEv.Err(err).Caller().
Str("statement", statement).
Msg("Failed to execute alter statement")
return err
}
}
return nil
}
func (m *Pre2021Migrator) migrateSectionsToNewDB() error {

11
cmd/gochan-migration/internal/pre2021/boards_test.go
View file

@ -1,7 +1,9 @@
package pre2021
import (
"context"
"testing"
"time"
"github.com/gochan-org/gochan/pkg/gcsql"
"github.com/stretchr/testify/assert"
@ -76,4 +78,13 @@ func TestMigrateBoardsInPlace(t *testing.T) {
if !assert.NoError(t, migrator.MigrateBoards()) {
t.FailNow()
}
ctx, cancel := context.WithTimeout(context.Background(), time.Second*time.Duration(migrator.config.DBTimeoutSeconds))
defer cancel()
var uri string
var sectionID int
assert.NoError(t, migrator.db.QueryRowContextSQL(ctx, nil, "SELECT uri FROM DBPREFIXboards WHERE dir = ?", []any{"test"}, []any{&uri}))
assert.NoError(t, migrator.db.QueryRowContextSQL(ctx, nil, "SELECT section_id FROM DBPREFIXboards WHERE dir = ?", []any{"test"}, []any{&sectionID}))
assert.Equal(t, "", uri)
assert.Greater(t, sectionID, 0)
}

19
cmd/gochan-migration/internal/pre2021/queries.go
View file

@ -21,3 +21,22 @@ timestamp, expires, permaban, reason, type, staff_note, appeal_at, can_appeal FR
announcementsQuery = "SELECT id, subject, message, poster, timestamp FROM DBPREFIXannouncements"
)
var (
alterStatements = []string{
"ALTER TABLE DBPREFIXboards RENAME COLUMN section TO section_id",
"ALTER TABLE DBPREFIXboards RENAME COLUMN list_order TO navbar_position",
"ALTER TABLE DBPREFIXboards RENAME COLUMN created_on TO created_at",
"ALTER TABLE DBPREFIXboards RENAME COLUMN anonymous TO anonymous_name",
"ALTER TABLE DBPREFIXboards RENAME COLUMN forced_anon TO force_anonymous",
"ALTER TABLE DBPREFIXboards RENAME COLUMN embeds_allowed TO allow_embeds",
"ALTER TABLE DBPREFIXboards ADD COLUMN uri VARCHAR(45) NOT NULL DEFAULT ''",
"ALTER TABLE DBPREFIXboards ADD COLUMN min_message_length SMALLINT NOT NULL DEFAULT 0",
"ALTER TABLE DBPREFIXboards ADD COLUMN max_threads SMALLINT NOT NULL DEFAULT 65535",
// the following statements don't work in SQLite since it doesn't support adding foreign keys after table creation.
// "in-place" migration support for SQLite may be removed
"ALTER TABLE DBPREFIXboards ADD CONSTRAINT boards_section_id_fk FOREIGN KEY (section_id) REFERENCES DBPREFIXsections(id)",
"ALTER TABLE DBPREFIXboards ADD CONSTRAINT boards_dir_unique UNIQUE (dir)",
"ALTER TABLE DBPREFIXboards ADD CONSTRAINT boards_uri_unique UNIQUE (uri)",
}
)