Use different functions for cookie return types

frontend/src/cookies.js

@@ -3,8 +3,8 @@ import $ from "jquery";
 /**
  * @param {string} name
  */
-export function getCookie(name, options = {type: "string"}) {
-	let val = options.default;
+export function getCookie(name, defaultVal = "") {
+	let val = defaultVal;
 	let cookieArr = document.cookie.split("; ");
 
 	for(const cookie of cookieArr) {
@@ -13,29 +13,20 @@ export function getCookie(name, options = {type: "string"}) {
 		try {
 			val = decodeURIComponent(pair[1]);
 		} catch(err) {
-			return options.default;
+			return defaultVal;
 		}
 	}
-	switch(options.type) {
-		case "int":
-			return parseInt(val);
-		case "float":
-			return parseFloat(val);
-		case "bool":
-		case "boolean":
-			return val == "true" || val == "1";
-		case "json":
-			try {
-				return JSON.parse(val);
-			} catch(e) {
-				return {};
-			}
-	}
-	if(val == undefined)
-		val = "";
 	return val;
 }
 
+export function getNumberCookie(name, defaultVal = "0") {
+	return parseFloat(getCookie(name, defaultVal))
+}
+
+export function getBooleanCookie(name, defaultVal = "true") {
+	return getCookie(name, defaultVal) == "true";
+}
+
 function randomPassword(len = 8) {
 	const printableStart = 33;
 	const printableEnd = 126;

frontend/src/manage.js

@@ -173,41 +173,3 @@ export function createStaffMenu(rank = staffInfo.Rank) {
 			$topbar.after($staffMenu);
 	});
 }
-
-/**
- * Opens a lightbox for using staff tools without having to go load the page
- * @param {string} actionURL The URL to get the action HTML from
- * @deprecated
- */
-export function openStaffLightBox(actionURL) {
-	$.ajax({
-		method: 'GET',
-		url: `${webroot}manage`,
-		data: {
-			action: actionURL,
-		},
-		dataType:"html",
-		async:false,
-
-		success: result => {
-			let body = `<div id="body-mock">${result.replace(/^[\s\S]*<body.*?>|<\/body>[\s\S]*$/ig, "")}</div>`;
-			let $body = $(body);
-			let header = $body.find("h1");
-			let headerText = header.text();
-			header.remove();
-			if(headerText == "") headerText = "Manage";
-			showLightBox(headerText,$body.html());
-		},
-		error: result => {
-			let responseText = result.responseText;
-			header = responseText.substring(responseText.indexOf("<h1>")+4,responseText.indexOf("</h1>"));
-
-			responseText = responseText.substring(responseText.indexOf("</h1>") + 5, responseText.indexOf("</body>"));
-			if(header == "") {
-				showLightBox("Manage", responseText);
-			} else {
-				showLightBox(header, responseText);
-			}
-		}
-	});
-}

frontend/src/postutil.js

@@ -190,7 +190,10 @@ export function reportPost(id, board) {
 		};
 		xhrFields[`check${id}`] = "on";
 		$.post(webroot + "util", xhrFields).fail(data => {
-			alertLightbox(`Report failed: ${data.error}`, "Error");
+			let errStr = data.error;
+			if(errStr == undefined)
+				errStr = data.statusText;
+			alertLightbox(`Report failed: ${errStr}`, "Error");
 		}).done(data => {
 			alertLightbox("Report sent", "Success");
 		}, "json");

frontend/src/storage.js

@@ -1,14 +1,11 @@
 import { getCookie, setCookie } from "./cookies";
 
 
-/**
- * @returns {string}
- */
-export function getStorageVal(key, defaultVal) {
+export function getStorageVal(key, defaultVal = "") {
 	if(localStorage == undefined)
-		return getCookie(key, {default: defaultVal, type: "string"});
+		return getCookie(key, defaultVal);
 	let val = localStorage.getItem(key);
-	if(val === null && defaultVal !== undefined)
+	if(val === null)
 		return defaultVal;
 	return val;
 }